Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Do not allow linear solver fail feature #3274

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

feat: Do not allow linear solver fail feature #3274

wants to merge 15 commits into from

Conversation

jafranc
Copy link
Contributor

@jafranc jafranc commented Aug 8, 2024

Add flags and logic to drop nonlinear loop if a linear step ends up in NonConverged state.

@jafranc jafranc self-assigned this Aug 8, 2024
@jafranc jafranc marked this pull request as ready for review August 9, 2024 15:51
@jafranc jafranc added type: new A new issue has been created and requires attention type: feature New feature or request labels Aug 9, 2024
@jafranc jafranc changed the title Do not allow linear solver fail feature feat: Do not allow linear solver fail feature Aug 9, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (50504b5) to head (02e8091).

Files with missing lines Patch % Lines
...oreComponents/physicsSolvers/PhysicsSolverBase.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3274   +/-   ##
========================================
  Coverage    56.79%   56.79%           
========================================
  Files         1168     1168           
  Lines       101395   101403    +8     
========================================
+ Hits         57586    57593    +7     
- Misses       43809    43810    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jafranc jafranc requested a review from CusiniM August 12, 2024 18:53
@paveltomin paveltomin added type: cleanup / refactor Non-functional change (NFC) flag: requires rebaseline Requires rebaseline branch in integratedTests and removed type: new A new issue has been created and requires attention labels Dec 20, 2024
@paveltomin
Copy link
Contributor

@CusiniM @rrsettgast this should be good to go

@jafranc jafranc added ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Jan 23, 2025
@jafranc
Copy link
Contributor Author

jafranc commented Jan 23, 2025

@paveltomin I tried pushing this to merge queue adding flags to trigger all required testing. Is it still a must-rebaseline as we add to the registered vars or did the baseline logic changed ?

@paveltomin
Copy link
Contributor

@paveltomin I tried pushing this to merge queue adding flags to trigger all required testing. Is it still a must-rebaseline as we add to the registered vars or did the baseline logic changed ?

I think you did everything correctly but tests job just randomly failed on the compilation
This PR should require rebaseline, nothing changed for that
And it can not go into merge queue yet since there are no reviews

@paveltomin paveltomin removed ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run code coverage enables running of the code coverage CI jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@paveltomin paveltomin

@jafranc jafranc

Labels
flag: ready for review flag: requires rebaseline Requires rebaseline branch in integratedTests type: cleanup / refactor Non-functional change (NFC) type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jafranc @paveltomin @CusiniM